| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Georgios Kokolatos <gkokolatos(at)pm(dot)me> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Fabien Coelho <postgresql(dot)org(at)coelho(dot)net> |
| Subject: | Re: CPU costs of random_zipfian in pgbench |
| Date: | 2019-03-13 09:49:23 |
| Message-ID: | alpine.DEB.2.21.1903131048290.4059@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> For whatever it is worth, the patch looks good to me.
>
> A minor nitpick would be to use a verb in the part:
>
> `cost when the parameter in (0, 1)`
> maybe:
>
> `cost when the parameter's value is in (0, 1)` or similar.
Looks ok.
> Apart from that, I would suggest it that the patch could be moved to
> Waiting for Author state.
Attached an upated.
--
Fabien.
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-zipf-doc-3.patch | text/x-diff | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2019-03-13 09:51:53 | Re: WIP: BRIN multi-range indexes |
| Previous Message | Amit Langote | 2019-03-13 09:44:58 | Re: Inadequate executor locking of indexes |