| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | "Jamison, Kirk" <k(dot)jamison(at)jp(dot)fujitsu(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: pgbench - doCustom cleanup |
| Date: | 2019-03-04 08:40:28 |
| Message-ID: | alpine.DEB.2.21.1903040940180.15713@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Kirk,
> so I tried to apply the patch, but part of the chunk failed,
> because of the unused line below which was already removed in the
> recent related commit.
>> PGResult *res;
> I removed the line and fixed the other trailing whitespaces.
Indeed. Thanks for the fix.
> See the attached latest patch.
> The attached patch applies, builds cleanly,
> and passes the regression tests.
[...]
> No problems on my part as I find the changes logical.
> This also needs a confirmation from Alvaro.
Ok.
You switched the patch to "waiting on author": What are you waiting from
me?
If you think that it is ok and that it should be considered by a
committer, probably Alvaro, it can be marked as "ready".
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2019-03-04 09:04:20 | Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid |
| Previous Message | Amit Khandekar | 2019-03-04 08:39:52 | Re: Minimal logical decoding on standbys |