| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Bernd Helmle <mailings(at)oopsware(dot)de> |
| Cc: | Michael Banck <michael(dot)banck(at)credativ(dot)de>, Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Offline enabling/disabling of data checksums |
| Date: | 2019-01-08 15:17:55 |
| Message-ID: | alpine.DEB.2.21.1901081614210.32421@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>> Adding a new state to ControlFileData which would prevent it from
>> starting?
>
> But then you have to make sure the control flag gets cleared in any
> case pg_verify_checksums crashes somehow or gets SIGKILL'ed ...
The usual approach is a restart with some --force option?
> Setting the checksum flag is done after having finished all blocks, so
> there is no problem.
There is also a problem if the db is started while the checksum is being
enabled.
> But we need to set this new flag before and reset it afterwards, so in
> between strange things can happen (as the various calls to exit() within
> error handling illustrates).
Sure, there is some need for a backup plan if it fails and the control
file is let in a wrong state.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2019-01-08 15:25:05 | Re: Offline enabling/disabling of data checksums |
| Previous Message | Stephen Frost | 2019-01-08 15:06:24 | Re: Mentoring for GCI-19 |