| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Michael Banck <michael(dot)banck(at)credativ(dot)de> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Online verification of checksums |
| Date: | 2018-12-25 09:25:46 |
| Message-ID: | alpine.DEB.2.21.1812250943120.32444@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hallo Michael,
> Yeah, new rebased version attached.
Patch v8 applies cleanly, compiles, global & local make check are ok.
A few comments:
About added tests: the node is left running at the end of the script,
which is not very clean. I'd suggest to either move the added checks
before stopping, or to stop again at the end of the script, depending on
the intention.
I'm wondering (possibly again) about the existing early exit if one block
cannot be read on retry: the command should count this as a kind of bad
block, proceed on checking other files, and obviously fail in the end, but
having checked everything else and generated a report. I do not think that
this condition warrants a full stop. ISTM that under rare race conditions
(eg, an unlucky concurrent "drop database" or "drop table") this could
happen when online, although I could not trigger one despite heavy
testing, so I'm possibly mistaken.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2018-12-25 09:32:34 | Re: pg_dumpall --exclude-database option |
| Previous Message | Michael Paquier | 2018-12-25 09:05:59 | Re: pg_dumpall --exclude-database option |