| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: fix psql \conninfo & \connect when using hostaddr |
| Date: | 2018-11-17 14:32:10 |
| Message-ID: | alpine.DEB.2.21.1811171530020.16105@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 17 Nov 2018, Alvaro Herrera wrote:
>> /* ----------
>> * getHostaddr -
>> * Fills 'host_addr' with the string representation of the currently connected
>> * socket in 'conn'.
>> * ----------
>> */
>> static void
>> getHostaddr(PGconn *conn, char *host_addr, int host_addr_len)
> Fabien, are you planning to fix things per Arthur's review?
Yep, I am.
I will not do the above though, because the PQgetHostaddr API would differ
from all other connection status functions (PQgetHost, PQgetUser...) which
are all "char * PQget<Something>(PGconn * conn)"
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2018-11-17 14:36:55 | Re: fix psql \conninfo & \connect when using hostaddr |
| Previous Message | Alvaro Herrera | 2018-11-17 14:15:54 | Re: Accounting of zero-filled buffers in EXPLAIN (BUFFERS) |