From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
---|---|
To: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Adding a note to protocol.sgml regarding CopyData |
Date: | 2018-07-30 17:29:31 |
Message-ID: | alpine.DEB.2.21.1807301325100.16328@lancre |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello Tatsuo-san,
Minor suggestions, although I'm not a native English speaker.
> In libpq.sgml following is stated:
>
> Before <productname>PostgreSQL</productname> protocol 3.0, it was necessary
> for the application to explicitly send the two characters
> <literal>\.</literal> as a final line to indicate to the server that it
ISTM That "it" may refer to the server... Put "the application" instead?
> had
> finished sending <command>COPY</command> data. While this still works, it is deprecated and the
> special meaning of <literal>\.</literal> can be expected to be removed in a
> future release.
Maybe be more assertive, "will be removed"?
> It is sufficient to call <function>PQendcopy</function> after
"It is now sufficient ..."?
> having sent the actual data.
>
> I think this should be mentioned in protocol.sgml as well. Developers
> who wish to develop programs that understand frontend/backend protocol
> should be able to focus on protocol.sgml. Attached is a patch for
> this.
--
Fabien.
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2018-07-30 18:21:38 | Re: Making "COPY partitioned_table FROM" faster |
Previous Message | Alexander Kuzmenkov | 2018-07-30 17:13:21 | Re: [HACKERS] PoC: full merge join on comparison clause |