From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pgbench's expression parsing & negative numbers |
Date: | 2018-07-19 12:38:40 |
Message-ID: | alpine.DEB.2.21.1807190834180.9171@lancre |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>>> I'll come up with a patch for that sometime soon.
>>
>> ISTM that you have not sent any patch on the subject, otherwise I would
>> have reviewed it. Maybe I could do one some time later, unless you think
>> that I should not.
>
> Here is a patch which detects pgbench overflows on int & double constants,
> and on integer operators.
... it but forgot to handle parsing min int, which was the initial focus
of this thread.
This patch does that as well by handling it as the special case between
lexer & parser (the issue being that 9223372036854775808 cannot be lexed
as an standard integer, as it is too large, and -9223372036854775808 is
really two tokens, so must be managed from the parser).
--
Fabien.
Attachment | Content-Type | Size |
---|---|---|
pgbench-overflow-3.patch | text/plain | 14.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2018-07-19 12:42:24 | Re: Runtime partition pruning for MergeAppend |
Previous Message | David Rowley | 2018-07-19 12:36:17 | Re: Runtime partition pruning for MergeAppend |