| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Marina Polyakova <m(dot)polyakova(at)postgrespro(dot)ru>, Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru>, pgsql-hackers(at)postgresql(dot)org, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Subject: | Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors |
| Date: | 2018-05-08 19:22:14 |
| Message-ID: | alpine.DEB.2.21.1805082111290.14747@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Alvaro,
>> I think that I'll have time for a round of review in the first half of July.
>> Providing a rebased patch before then would be nice.
> Note that even in the absence of a rebased patch, you can apply to an
> older checkout if you have some limited window of time for a review.
Yes, sure. I'd like to bring this feature to be committable, so it will
have to be rebased at some point anyway.
> Looking over the diff, I find that this patch tries to do too much and
> needs to be split up.
Yep, I agree that it would help the reviewing process. On the other hand I
have bad memories about maintaining dependent patches which interfere
significantly. Maybe it may not the case with this feature.
Thanks for the advices.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-05-08 19:36:21 | Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors |
| Previous Message | Andrew Dunstan | 2018-05-08 17:57:47 | perlcritic script |