Re: PATCH: pgbench - option to build using ppoll() for larger connection counts

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: "Rady, Doug" <radydoug(at)amazon(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: PATCH: pgbench - option to build using ppoll() for larger connection counts
Date: 2018-03-25 11:00:20
Message-ID: alpine.DEB.2.20.1803251252390.8109@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Doug,

> Updated the patch to not do the #undef
> pgbench11-ppoll-v11.patch attached.

Patch applies. Do not forget to regenerate configure to test...

I've compiled and run with both ppoll & select options without issues.

Two quite minor style comment (at least 2 instances):

if (cond) return false; else return true;

ISTM that the simpler the better:

return !cond;

Also ISTM that the following does not comply with pg C style expectations
(idem, 2 instances):

} else {

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Haribabu Kommi 2018-03-25 11:27:09 Re: PQHost() undefined behavior if connecting string contains both host and hostaddr types
Previous Message David Rowley 2018-03-25 10:43:40 Re: ALTER TABLE ADD COLUMN fast default