Re: General purpose hashing func in pgbench

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Ildar Musin <i(dot)musin(at)postgrespro(dot)ru>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: General purpose hashing func in pgbench
Date: 2018-01-28 08:10:11
Message-ID: alpine.DEB.2.20.1801280851260.17596@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Ildar,

> I did everything you mention here and attached a new version on the patch.

Patch applies, compiles, runs ok.

Alas, I still have a few more very minor comments about the doc, sorry
again:

+ <entry> <literal>default_seed</literal> </entry>
+ <entry>random seed used in hash functions by default</entry>

s/random //: the seed may or may not be random.

The "In some cases several distinct distributions..." paragraph is also
just one line in the xml source file. It should be justified at about 80
columns like others.

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2018-01-28 08:17:46 Re: Best way to select a random row from a derived table
Previous Message Ryan Murphy 2018-01-28 06:39:33 Best way to select a random row from a derived table