Re: proposal: psql command \graw

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: proposal: psql command \graw
Date: 2017-11-10 07:12:35
Message-ID: alpine.DEB.2.20.1711100805070.28452@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


>> ISTM that you can remove "force_column_header" and just set "tuple_only"
>> to what you need, that is you do not need to change anything in function
>> "print_unaligned_text".
>
> Last point is not possible - I would not to break original tuple only mode.

Hmmm... I do not understand. I can see only one use of force_column_header
in the function:

- if (!opt_tuples_only)
+ if (!opt_tuples_only || opt_force_column_header)

So I would basically suggest to do:

my_popt.topt.tuples_only = !pset.g_raw_header;

in the driver. Looking at the detailed code in that function, probably you
need to set start_table to on when headers are needed and stop_table to
off for the raw mode anyway?

Maybe I'm missing something, but it looks that it could be made to work
without adding another boolean.

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2017-11-10 07:17:02 Re: proposal: psql command \graw
Previous Message Kyotaro HORIGUCHI 2017-11-10 07:07:01 Re: path toward faster partition pruning