Re: pgsql: Remove pgbench "progress" test pending solution of its timing is

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Remove pgbench "progress" test pending solution of its timing is
Date: 2017-09-24 06:19:23
Message-ID: alpine.DEB.2.20.1709240809330.4999@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


> You are attacking a straw man.

I thought it was tilting at windmills:-)

> In the TAP-test context, you do have quite a bit of freedom to decide
> what is a pass and what is a fail. So maybe the path forward is to be
> more flexible about the pass conditions for this test.

Hmmm. I'm not sure that there is a solution under "any" testing conditions
if -T & -P are to be tested and some sensible output expected out of them.
I'll think about it.

> But I can't help thinking that these results have exposed some outright
> bugs too.

Yep, I agree that there is probably one bug/race/unexpected condition wrt
what is output and time out handling.

--
Fabien.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Fabien COELHO 2017-09-24 09:35:06 Re: pgsql: Remove pgbench "progress" test pending solution of its timing is
Previous Message Peter Eisentraut 2017-09-24 04:42:23 pgsql: doc: Expand user documentation on SCRAM