Re: psql: new help related to variables are not too readable

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org
Subject: Re: psql: new help related to variables are not too readable
Date: 2017-09-13 19:46:44
Message-ID: alpine.DEB.2.20.1709132051000.8924@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Tom,

>> Probably it needs some rebase after Tom committed result status variables.
>
>> As it is a style thing, ISTM that the patch is ready if most people agree
>> that it is better this way and there is no strong veto against.
>
> FWIW, I think it's a bad idea. We already nearly-doubled the vertical
> space required for this variable list. That was a heavy cost --- and we
> already got at least one complaint about it --- but it seemed warranted
> to avoid having to deal with very constrained variable descriptions.
> This proposes to make the vertical space nearly triple what it was in v10.
> In a typical-size window that's going to have a pretty severe impact on
> how much of the list you can see at once. And the readability gain is
> (at least to my eyes) very marginal.

Ok, you do not like it. As Pavel said, it is subjective. When it is a
matter of taste, people tend to differ, someone will always complain, one
way or another, and they are neither right nor wrong.

So, is it a -1 or a veto?

If it is the later, the patch can be marked as "Rejected" and everybody
will get more time for other things:-)

If it is a not a veto, people can continue to give their opinions.
Personnally I'm fine with a pager, so vertical spacing is fine. I just do
not like paging horizontally.

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Janes 2017-09-13 21:28:34 uninterruptible state in 10beta4
Previous Message Pierre Ducroquet 2017-09-13 17:53:50 Re: Small patch for pg_basebackup argument parsing