| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgbench - minor fix for meta command only scripts |
| Date: | 2017-09-12 01:27:13 |
| Message-ID: | alpine.DEB.2.20.1709120303290.8852@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Jeff,
> Shouldn't we use pg_usleep to ensure portability? it is defined for
> front-end code. But it returns void, so the error check will have to be
> changed.
Attached v3 with pg_usleep called instead.
> I didn't see the problem before the commit I originally indicated , so I
> don't think it has to be back-patched to before v10.
Hmmm.... you've got a point, although I'm not sure how it could work
without sleeping explicitely. Maybe the path was calling select with an
empty wait list plus timeout, and select is kind enough to just sleep on
an empty list, or some other miracle. ISTM clearer to explicitely sleep in
that case.
--
Fabien.
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-rate-bug-3.patch | text/x-diff | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-09-12 01:55:47 | Removing wal_keep_segments as default configuration in PostgresNode.pm |
| Previous Message | Michael Paquier | 2017-09-12 01:20:37 | Re: Still another race condition in recovery TAP tests |