From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: merge psql ef/ev sf/sv handling functions |
Date: | 2017-09-07 05:19:59 |
Message-ID: | alpine.DEB.2.20.1709070716120.17848@lancre |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> you can't do this sort of thing:
>
> - psql_error("The server (version %s) does not support editing function source.\n",
> + psql_error("The server (version %s) does not support editing %s.\n",
> formatPGVersionNumber(pset.sversion, false,
> - sverbuf, sizeof(sverbuf)));
> + sverbuf, sizeof(sverbuf)),
> + is_func ? "function source" : "view definitions");
>
> It's too much of a pain in the rear for translators.
Argh, indeed, I totally forgot about translations. Usually there is a _()
hint for gettext.
> See
> https://www.postgresql.org/docs/devel/static/nls-programmer.html#nls-guidelines
> Usually we just use two independent messages, and that's what I did.
Yep, makes sense. Thanks for the fix.
--
Fabien.
From | Date | Subject | |
---|---|---|---|
Next Message | Tatsuro Yamada | 2017-09-07 05:25:04 | Re: ANALYZE command progress checker |
Previous Message | Kyotaro HORIGUCHI | 2017-09-07 05:12:12 | Re: Restricting maximum keep segments by repslots |