| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Adding -E switch to pg_dumpall |
| Date: | 2017-07-20 09:17:50 |
| Message-ID: | alpine.DEB.2.20.1707201106470.4496@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Michaël-san,
> Attached is a patch to add support for this switch. I am parking that
> in the next CF.
I'm in favor of this feature for consistency with pg_dump, and as the
environment variable workaround is not specially elegant and can induce
issues of its own.
Patch applies and compiles.
No special regression tests are provided, but this seems ok to me as it
just forward the option to pg_dump, which I have no doubt is heavily
tested. Or not. Anyway it is consistent...
Manually tested with UTF8, latin1 (including conversion errors), non
existing.
Code is straightforward. Doc and help are both fine.
Ok for me. I switched the status to "Ready for committers".
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2017-07-20 09:43:27 | Proposal about a "deep" versions for some jsonb functions |
| Previous Message | Neha Sharma | 2017-07-20 09:15:55 | Re: [TRAP: FailedAssertion] causing server to crash |