| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | Greg Stark <stark(at)mit(dot)edu>, Erik Rijkers <er(at)xs4all(dot)nl>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Daniel Verite <daniel(at)manitou-mail(dot)org>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, PostgreSQL <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org |
| Subject: | Re: \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if, \quit_unless) |
| Date: | 2017-02-13 21:06:53 |
| Message-ID: | alpine.DEB.2.20.1702132141300.8071@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Corey,
> I went back to master and re-applied v11, something must have gotten lost
> in translation.
Probably you need "git add" for added files?
About v14: patch applies, make check ok, psql tap tests ok.
All seems fine to me. Test coverage is better than a lot of other
features. Code & comments seem fine. Doc and example are clear enough to
me.
The level of messages in interactive is terse but informative when needed,
on errors and when commands are ignored. The only missing point is about
doing something to the prompt, but given the current messages ISTM that
this can wait for a follow-up patch. Robert Haas advice is to keep it
simple and short and in %R. There was also some suggestion to have a "show
the stack" command for debug, I think that this can wait as well.
I've turned again the CF entry to "ready for committers", to see what
committers thing about this new and simplified version.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Merlin Moncure | 2017-02-13 21:08:47 | Re: libpq Alternate Row Processor |
| Previous Message | Corey Huinker | 2017-02-13 21:05:35 | Re: \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if, \quit_unless) |