Re: extend pgbench expressions with functions

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: extend pgbench expressions with functions
Date: 2016-03-29 05:53:47
Message-ID: alpine.DEB.2.10.1603290725340.14994@sto
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


>> I guess the question here is whether we want the part-c patch, which
>> removes the historical \setrandom syntax. That's technically no
>> longer needed since we now can use random() as a function directly
>> inside \set commands, but we might want it anyway for backward
>> compatibility.

This patch is indeed a proposal.

>> Anybody have an opinion on that?
>
> +1 for nuking it. That's not worth the trouble maintaining it.

I share Michaël opinion.

Some arguments for removing it:

- \setrandom is syntactically inhomogeneous in the overall syntax,
and is now redundant

- switching to the \set syntax is pretty easy, see attached script

- custom scripts are short, they are used by few but
advance users, for which updating would not be an issue

- the parsing & execution codes are lengthy, repetitive...

--
Fabien.

Attachment Content-Type Size
remove_setrandom.pl text/x-perl 207 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-03-29 06:21:19 Re: Re: [COMMITTERS] pgsql: Sync tzload() and tzparse() APIs with IANA release tzcode2016c.
Previous Message Tom Lane 2016-03-29 05:09:39 Re: Re: [COMMITTERS] pgsql: Sync tzload() and tzparse() APIs with IANA release tzcode2016c.