Re: innocuous: pgbench does FD_ISSET on invalid socket

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: innocuous: pgbench does FD_ISSET on invalid socket
Date: 2016-02-15 10:56:03
Message-ID: alpine.DEB.2.10.1602151152450.18755@sto
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Alvaro,

> Any objections to changing it like this? I'd probably backpatch to 9.5,
> but no further (even though this pattern actually appears all the way
> back.)

My 0.02€: if the pattern is repeated, maybe a function which incorporates
the check would save lines and improve overall readability?

... = safePQsocket(...);

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2016-02-15 11:21:25 Re: [PROPOSAL] VACUUM Progress Checker.
Previous Message Dmitry Ivanov 2016-02-15 10:54:41 [WIP] ALTER ... OWNER TO ... CASCADE