Re: patch: version_stamp.pl: Add Git commit info to version if 'git' is specified

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Øyvind A(dot) Holm <sunny(at)sunbase(dot)org>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch: version_stamp.pl: Add Git commit info to version if 'git' is specified
Date: 2015-08-28 05:48:28
Message-ID: alpine.DEB.2.10.1508280733290.16616@sto
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> Salesforce did something similar in their internal build, and TBH I do
> not find it a good idea. The basic problem is it's completely
> misleading to equate the last commit with the source you actually built
> from, because that might not have been an unmodified file set.

Indeed. What I've done in an svn-based project is to build the stamp from
the Makefile basically when linking, that is really as late as possible.
The other good point is that svnversion adds 'M' for modified if the
source tree has uncommitted changes.

Maybe such an approach could be used with git to have something reliable.

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2015-08-28 07:02:03 Re: [BUGS] Compile fails on AIX 6.1
Previous Message Noah Misch 2015-08-28 05:24:28 Re: Raising our compiler requirements for 9.6