| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, digoal zhou <digoal(dot)zhou(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Let PostgreSQL's On Schedule checkpoint write buffer smooth spread cycle by tuning IsCheckpointOnSchedule? |
| Date: | 2015-07-03 05:38:15 |
| Message-ID: | alpine.DEB.2.10.1507030737110.9460@sto |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Simon,
> We could do better, but that is not a reason not to commit this, as is.
> Commit, please.
My 0,02€: Please do not commit without further testing...
I've submitted a patch to improve checkpoint write scheduling, including
X00 hours of performance test on various cases. This patch changes
significantly the load distribution over the whole checkpoint, and AFAICS
has been tested on rather small cases.
I'm not sure that the power 1.5 is the right one for all cases. For a big
checkpoint over 30 minutes, it may have, or not, very large and possibly
unwanted effects. Maybe the 1.5 factor should really be a guc. Well, what
I really think is that it needs performance measures.
In conclusion, and very egoistically, I would prefer if this patch could
wait for the checkpoint scheduling patch to be considered, as it would
basically invalidate the X00 hours of performance tests I ran:-)
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marco Atzeri | 2015-07-03 05:47:57 | PostgreSQL 9.5 Alpha 1 build fail with perl 5.22 |
| Previous Message | Fujii Masao | 2015-07-03 05:34:44 | Re: WAL logging problem in 9.4.3? |