Re: PATCH: remove nclients/nthreads constraint from pgbench

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: remove nclients/nthreads constraint from pgbench
Date: 2015-07-02 12:58:31
Message-ID: alpine.DEB.2.10.1507021456050.5962@sto
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> This doesn't behave correctly if you set -j to greater than -c, and also use
> the rate limit option:
> [...]
>
> I think that can be fixed by just setting nthreads internally to nclients, if
> nthreads > nclients. But please double-check that the logic used to calculate
> throttle_delay makes sense in general, when nthreads is not a multiple of
> nclients.

Indeed, I probably did not consider nthreads > nclients. The fix you
suggest seems ok. I'll check it before sending a new v3.

--
Fabien.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2015-07-02 13:02:13 Re: raw output from copy
Previous Message Fujii Masao 2015-07-02 12:31:46 Re: Support for N synchronous standby servers - take 2