Re: gaussian distribution pgbench

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Mitsumasa KONDO <kondo(dot)mitsumasa(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: gaussian distribution pgbench
Date: 2014-07-22 06:23:04
Message-ID: alpine.DEB.2.10.1407220818030.5360@sto
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> Please find attached 2 patches, which are a split of the patch discussed in
> this thread.

Please find attached a very minor improvement to apply a code (variable
name) simplification directly in patch A so as to avoid a change in patch
B. The cumulated patch is the same as previous.

> (A) add gaussian & exponential options to pgbench \setrandom
> the patch includes sql test files.
>
> There is no change in the *code* from previous already reviewed submissions,
> so I do not think that it needs another review on that account.
>
> However I have (yet again) reworked the *documentation* (for Andres Freund &
> Robert Haas), in particular both descriptions now follow the same structure
> (introduction, formula, intuition, rule of thumb and constraint). I have
> differentiated the concept and the option by putting the later in <literal>
> tags, and added a link to the corresponding wikipedia pages.
>
>
> Please bear in mind that:
> 1. English is not my native language.
> 2. this is not easy reading... this is maths, to read slowly:-)
> 3. word smithing contributions are welcome.
>
> I assume somehow that a user interested in gaussian & exponential
> distributions must know a little bit about probabilities...
>
>
>
> (B) add pgbench test variants with gauss & exponential.
>
> I have reworked the patch so as to avoid copy pasting the 3 test cases, as
> requested by Andres Freund, thus this is new, although quite simple, code. I
> have also added explanations in the documentation about how to interpret the
> "decile" outputs, so as to hopefully address Robert Haas comments.

--
Fabien.

Attachment Content-Type Size
gauss_A_3.patch text/x-diff 16.1 KB
gauss_B_3.patch text/x-diff 11.9 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-07-22 06:31:13 Re: [bug fix] Suppress "autovacuum: found orphan temp table" message
Previous Message Jeff Davis 2014-07-22 05:58:24 Re: Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls