From: | Arne Scheffer <scheffa(at)uni-muenster(dot)de> |
---|---|
To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
Cc: | "Timmer, Marius" <marius(dot)timmer(at)uni-muenster(dot)de>, pgsql-hackerspostgresqlorg <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] explain sortorder |
Date: | 2015-01-14 16:42:29 |
Message-ID: | alpine.DEB.2.02.1501141731430.3444@zivarne |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
we will also remove the following is lc_collate hint in the next version, showing only mandatory info as suggested.
/* for those who use COLLATE although their default is already the wanted */
if (strcmp(collname, localeptr) == 0)
{
appendStringInfo(sortorderInformation, " (%s is LC_COLLATE)", collname);
}
Anybody insisting on that?
Arne
Note: I see, at the moment we use the wrong default for DESC. We'll fix that.
On Wed, 14 Jan 2015, Heikki Linnakangas wrote:
> On 01/14/2015 05:26 PM, Timmer, Marius wrote:
>> Hello Heikki,
>>
>> abbreviated version:
>> Sorry, the problem is only the unhandy patch text format, not different
>> opinions how to proceed.
>>
>> Long version:
>> The v7 patch file already addressed your suggestions,
>> but the file contained serveral (old) local commits,
>> the new ones at the end of the patch text/file.
>
> Ah, missed that. I stopped reading when I saw the old stuff there :-).
>
>> v7.1 is attached and addresses this issue providing a clean patch file.
>
> Ok, thanks, will take a look.
>
>> V8 will - as mentioned - add missing docs and regression tests,
>
> Great!
>
> - Heikki
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2015-01-14 16:47:15 | Re: Compression of full-page-writes |
Previous Message | Robert Haas | 2015-01-14 16:38:41 | Re: Re: Patch to add functionality to specify ORDER BY in CREATE FUNCTION for SRFs |