From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
---|---|
To: | Greg Smith <greg(at)2ndQuadrant(dot)com> |
Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] pgbench --throttle (submission 7 - with lag measurement) |
Date: | 2013-07-15 19:02:36 |
Message-ID: | alpine.DEB.2.02.1307152047490.3991@localhost6.localdomain6 |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>> * ISTM that the impact of the chosen 1000 should appear somewhere.
>
> I don't have a problem with that, but I didn't see that the little table you
> included was enough to do that. I think if someone knows how this type of
> random generation works, they don't need the comment to analyze the impact.
> And if they don't know, that comment alone wasn't enough to help them figure
> it out. That's why I added some terms that might help point the right way
> for someone who wanted to search for more information instead.
Sure. I agree that comments are not the right place for a lecture about
Poisson stochastic processes. Only the "1000" parameter as an impact on
the maximum delay that can be incurred with respect do the target average
delay, and I think that this information is relevant for a comment.
> to generate numbers with a target probability distribution function.
> Normally the code comments tries to recommend references for this sort
> of thing instead. I didn't find a really good one in a quick search
> though.
Yep. Maybe "http://en.wikipedia.org/wiki/Exponential_distribution".
--
Fabien.
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2013-07-15 20:43:35 | Re: checking variadic "any" argument in parser - should be array |
Previous Message | Andrew Gierth | 2013-07-15 18:56:17 | Re: FILTER for aggregates [was Re: Department of Redundancy Department: makeNode(FuncCall) division] |