Re: Add more regression tests for dbcommands

From: Fabien COELHO <fabien(dot)coelho(at)mines-paristech(dot)fr>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robins Tharakan <tharakan(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add more regression tests for dbcommands
Date: 2013-05-13 15:36:28
Message-ID: alpine.DEB.2.02.1305131732440.1630@localhost6.localdomain6
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


>> As for the cost, if the proposed tests are indeed too costly, what is not
>> necessarily the case for what I have seen, I do not think that it would be a
>> great problem to have two set of tests, with one a superset of the other,
>> with some convention.
>
> Well, tests like permission tests aren't the expensive part. The actual
> CREATE/DROP DATABASE you

Not me, but "Robins Tharakan".

> do is. The latter essentially are already tested by the buildfarm
> already.

Yep, that is what Tom was arguing.

> So, trimming the patch to do only the fast stuff should be less
> controversial?

Yes, I think so.

I think that allowing "expensive" tests such as a full archive or
replication setup would be nice as well, so maybe having several level of
tests would be a good thing anyway.

--
Fabien.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2013-05-13 15:36:55 Re: lock support for aarch64
Previous Message Robins Tharakan 2013-05-13 15:34:01 Re: Add more regression tests for dbcommands