| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robins Tharakan <tharakan(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add more regression tests for dbcommands |
| Date: | 2013-05-13 05:58:08 |
| Message-ID: | alpine.DEB.2.02.1305130753130.23656@localhost6.localdomain6 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>> Please find attached a patch to take code-coverage of DBCommands (CREATE
>> DATABASE / ALTER DATABASE / DROP DATABASE) from 36% to 71%.
>
> I wish to object strenuously to adding any more CREATE/DROP DATABASE
> commands to the core regression tests. Those are at least one order of
> magnitude more expensive than any other commands we test, and the added
> code coverage is precisely zero because creation and dropping of a
> database is already done repeatedly in the contrib regression tests.
Would you be okay if there is one/a few effective create/drop (some tests
check that the create or drop fails e.g. depending on permissions, which
ISTM is not tested anywhere else), so that tests for various ALTER
DATABASE commands are combined together onto these databases?
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2013-05-13 06:53:53 | Re: Proposal to add --single-row to psql |
| Previous Message | Tom Lane | 2013-05-13 04:03:47 | Re: Add more regression tests for dbcommands |