On 27.01.25 13:42, Dean Rasheed wrote:
> On Mon, 27 Jan 2025 at 09:59, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>>
>> Here is an updated patch that integrates the above changes and also
>> makes some adjustments now that the logical replication configuration
>> questions are resolved. I think this is complete now.
>>
>
> In struct ResultRelInfo, the following field is added:
>
> int ri_NumGeneratedNeededI;
> int ri_NumGeneratedNeededU;
>
> + /* true if the above have been computed */
> + bool ri_Generated_valid;
> +
>
> but that doesn't really seem to be accurate, because it's set to true
> by ExecInitGenerated() whether it's called with CMD_INSERT or
> CMD_UPDATE, so it will be true before both the other fields are
> computed. It's used from ExecGetExtraUpdatedCols() as an indicator
> that ri_extraUpdatedCols is valid, but it looks like that might not be
> the case, if ExecInitGenerated() was only called with CMD_INSERT.
>
> I'm not sure if that represents an actual bug, but it looks wrong. It
> should perhaps be called "ri_extraUpdatedCols_valid", and only set to
> true when ExecInitGenerated() is called with CMD_UPDATE, and
> ri_extraUpdatedCols is populated.
Yeah, this is quite contorted. I have renamed it like you suggested.