Fix error message for MERGE foreign tables

From: bt22nakamorit <bt22nakamorit(at)oss(dot)nttdata(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Fix error message for MERGE foreign tables
Date: 2022-10-14 02:59:34
Message-ID: af88be42757c90e163fc4e27a2e29e0e@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

MERGE command does not accept foreign tables as targets.
When a foreign table is specified as a target, it shows error messages
like this:

-- ERROR: cannot execute MERGE on relation "child1"
-- DETAIL: This operation is not supported for foreign tables.

However, when a partitioned table includes foreign tables as partitions
and MERGE is executed on the partitioned table, following error message
shows.

-- ERROR: unexpected operation: 5

The latter error message is unclear, and should be the same as the
former one.
The attached patch adds the code to display error the former error
messages in the latter case.
Any thoughts?

Best,
Tatsuhiro Nakamori

Attachment Content-Type Size
fdw_errmsg.patch text/x-diff 510 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-10-14 03:14:57 Re: GUC values - recommended way to declare the C variables?
Previous Message Junwang Zhao 2022-10-14 02:59:28 [meson] add missing pg_attribute_aligned for MSVC in meson build