Re: Minor documentation error regarding streaming replication protocol

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Brar Piening <brar(at)gmx(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Minor documentation error regarding streaming replication protocol
Date: 2020-12-03 17:04:21
Message-ID: af6eaa71451e949521e99eb4e7f2a3d04554ebf7.camel@j-davis.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 2020-12-02 at 15:16 -0500, Bruce Momjian wrote:
> Yes, we could, but I thought the format code was not something we set
> at
> this level. Looking at byteasend() it is true it just sends the
> bytes.

It can be set along with the type. Attached an example.

Andres objected (in a separate conversation) to forcing a binary-format
value on a client that didn't ask for one. He suggested that we mandate
that the data is ASCII-only (for both filename and content), closing
the gap Michael raised[1]; and then just declare all values to be text
format.

I am fine with either approach; but in any case, I don't see the point
in sending an incorrect RowDescription.

Regards,
Jeff Davis

[1] https://postgr.es/m/20201008235250.GA1528@paquier.xyz

Attachment Content-Type Size
timeline-history-proto.diff text/x-patch 6.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2020-12-03 17:53:59 Re: Add Information during standby recovery conflicts
Previous Message Nikolay Samokhvalov 2020-12-03 17:03:47 Re: Commitfest 2020-11 is closed