Re: Thinking about EXPLAIN ALTER TABLE

From: Jose Luis Tallon <jltallon(at)adv-solutions(dot)net>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: Thinking about EXPLAIN ALTER TABLE
Date: 2018-12-11 11:29:44
Message-ID: af3624a6-5b53-1278-ad8b-8aecc81c7437@adv-solutions.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>>> We were just busy shooting down a different suggestion of
>>> behavior-changing GUCs. A GUC that turns all ALTERs into no-ops
>>> sure seems like a foot-gun to me.
>> Yeah, I like EXPLAIN better.
> +1 for EXPLAIN

IMVHO, and for "symmetry" with existing mechanisms:

* EXPLAIN ALTER TABLE    ==> "DDL dry run", but tell me what would be
done (similar to what EXPLAIN SELECT does)

* EXPLAIN PERFORM ALTER TABLE    (EXPLAIN EXEC?)    would explain + do

    ...and bonus points for explaining each step just before it is
performed. This way, It'd be easy for users to verify that a particular
step (i.e. table rewrite) is the one taking æons to run or hammering the
storage.

    Of course, regular "ALTER TABLE" stays as it is.

Just my .02€ :)

I'm not familiar with this part of the code and clearly can't devote
enough time to do it in the near future, but count on me to test it if
accepted.

Thanks,

    Jose

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Banck 2018-12-11 11:43:23 Re: Record last password change
Previous Message Gavin Flower 2018-12-11 10:45:29 Re: Record last password change