| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Boundary value check in lazy_tid_reaped() |
| Date: | 2021-03-08 10:16:16 |
| Message-ID: | af1e195d-9dde-5666-a80f-2091a22c90c9@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 21.01.21 14:11, Masahiko Sawada wrote:
> Agreed. bsearch with bound check showed a reasonable improvement in my
> evaluation in terms of performance. Regarding memory efficiency, we
> can experiment with other methods later.
>
> I've attached the patch that adds a bound check for encoded
> itermpointers before bsearch() in lazy_tid_reaped() and inlines the
> function.
Do you have any data showing the effect of inlining lazy_tid_reaped()?
I mean, it probably won't hurt, but it wasn't part of the original patch
that you tested, so I wonder whether it has any noticeable effect.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Laurenz Albe | 2021-03-08 10:19:55 | Re: Using COPY FREEZE in pgbench |
| Previous Message | Dilip Kumar | 2021-03-08 10:02:39 | Re: [HACKERS] Custom compression methods |