| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Subject: | Re: Virtual generated columns |
| Date: | 2025-01-14 09:58:20 |
| Message-ID: | aede1a3b-2b87-435d-84bf-eeede3ee95e4@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 09.01.25 13:41, jian he wrote:
> we can not ALTER COLUMN DROP EXPRESSION for virtual for now.
> so the following comments in generated_virtual.sql conflict with the output.
> ```
> -- check that dependencies between columns have also been removed
> ALTER TABLE gtest29 DROP COLUMN a; -- should not drop b
> \d gtest29
> ```
> we can also comment out line 557 in generated_virtual.sql.
Ok will do.
> attach patch is removing unnecessary parentheses from
> ```ereport(ERROR, (errcode```
> only for this patch related.
> per commit https://git.postgresql.org/cgit/postgresql.git/commit/?id=e3a87b4991cc2d00b7a3082abb54c5f12baedfd1
>
> also https://www.postgresql.org/docs/current/error-message-reporting.html says
> ""The extra parentheses were required before PostgreSQL version 12,
> but are now optional.""
Right. I tried to keep it mostly consistent with existing surrounding
code, but I will do another pass to improve that.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2025-01-14 10:41:42 | Re: Retiring is_pushed_down |
| Previous Message | Dean Rasheed | 2025-01-14 09:50:51 | Re: Psql meta-command conninfo+ |