Re: Strip -mmacosx-version-min options from plperl build

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Strip -mmacosx-version-min options from plperl build
Date: 2022-08-26 14:04:35
Message-ID: aea9bb91-2359-e5be-0fbf-3f721af4cbe4@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2022-08-25 Th 18:13, Andres Freund wrote:
> Hi,
>
> On 2022-08-25 18:04:34 -0400, Andrew Dunstan wrote:
>> On 2022-08-25 Th 17:47, Andres Freund wrote:
>>>> $ egrep '_PG_init|Pg_magic_func'  plperl.i
>>>> extern __attribute__((visibility("default"))) void _PG_init(void);
>>>> extern __attribute__((visibility("default"))) const Pg_magic_struct
>>>> *Pg_magic_func(void); const Pg_magic_struct * Pg_magic_func(void) {
>>>> static const Pg_magic_struct Pg_magic_data = { sizeof(Pg_magic_struct),
>>>> 160000 / 100, 100, 32, 64,
>>>> _PG_init(void)
>>> Could you show objdump -t of the library? Perhaps once with the flags as now,
>>> and once relinking with the "old" flags that we're now omitting?
>>
>> current:
>>
>>
>> $ objdump -t plperl.dll | egrep '_PG_init|Pg_magic_func'
>> [103](sec  1)(fl 0x00)(ty  20)(scl   2) (nx 0) 0x00000000000040a0
>> Pg_magic_func
>> [105](sec  1)(fl 0x00)(ty  20)(scl   2) (nx 0) 0x00000000000040b0 _PG_init
>>
>>
>> from July 11th build:
>>
>>
>> $ objdump -t plperl.dll | egrep '_PG_init|Pg_magic_func'
>> [101](sec  1)(fl 0x00)(ty  20)(scl   2) (nx 0) 0x00000000000040d0
>> Pg_magic_func
>> [103](sec  1)(fl 0x00)(ty  20)(scl   2) (nx 0) 0x00000000000040e0 _PG_init
> Thanks.
>
> So it looks like it's not the symbol not being exported. I wonder if the image
> base thing is somehow the problem? Sounds like it should just be an efficiency
> difference, by avoiding some relocations, not a functional difference.
>
> Can you try adding just that to the flags for building and whether that then
> allows a LOAD 'plperl' to succeed?
>

Adding what?

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2022-08-26 14:06:11 Re: standby promotion can create unreadable WAL
Previous Message Andres Freund 2022-08-26 13:40:47 Re: windows cfbot failing: my_perl