Re: broken master regress tests

Hello Jeff,

22.12.2023 02:17, Jeff Davis wrote:
> On Wed, 2023-12-20 at 17:48 -0800, Jeff Davis wrote:
>> Attached.
> It appears to increase the coverage. I committed it and I'll see how
> the buildfarm reacts.

Starting from the commit 8793c6005, I observe a failure of test
collate.windows.win1252 on Windows Server 2016:
meson test regress/regress
1/1 postgresql:regress / regress/regress        ERROR 24.47s   exit status 1

regression.diffs contains:
@@ -993,6 +993,8 @@
 -- nondeterministic collations
 -- (not supported with libc provider)
 CREATE COLLATION ctest_det (locale = 'en_US', deterministic = true);
+ERROR:  could not create locale "en_US": No such file or directory
+DETAIL:  The operating system could not find any locale data for the locale name "en_US".
 CREATE COLLATION ctest_nondet (locale = 'en_US', deterministic = false);
 ERROR:  nondeterministic collations not supported with this provider
 -- cleanup

Though
CREATE COLLATION ctest_det (locale = 'English_United States', deterministic = true);
executed successfully on this OS.

AFAICS, before that commit SELECT getdatabaseencoding() in the test
returned SQL_ASCII, hence the test was essentially skipped, but now it
returns WIN1252, so problematic CREATE COLLATION(locale = 'en_US', ...)
is reached.

Best regards,
Alexander