Re: split TOAST support out of postgres.h

On 10.01.23 09:48, Peter Eisentraut wrote:
> On 10.01.23 08:39, Noah Misch wrote:
>> On Tue, Jan 10, 2023 at 06:07:49AM +0100, Peter Eisentraut wrote:
>>> On 30.12.22 17:50, Tom Lane wrote:
>>>> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
>>>>> On 28.12.22 16:07, Tom Lane wrote:
>>>>>> I dunno, #3 seems kind of unprincipled.  Also, since fmgr.h is
>>>>>> included
>>>>>> so widely, I doubt it is buying very much in terms of reducing header
>>>>>> footprint.  How bad is it to do #2?
>>>>
>>>>> See this incremental patch set.
>>>>
>>>> Wow, 41 files requiring varatt.h is a lot fewer than I would have
>>>> guessed.
>>>> I think that bears out my feeling that fmgr.h wasn't a great location:
>>>> I count 117 #includes of that, many of which are in .h files themselves
>>>> so that many more .c files would be required to read them.
>>>
>>> committed
>>
>> SET_VARSIZE alone appears in 74 pgxn distributions, so I predict
>> extension
>> breakage en masse.  I would revert this.
>
> Well, that was sort of my thinking, but people seemed to like this.  I'm
> happy to consider alternatives.

Given the subsequent discussion, I'll keep it as is for now but consider
it a semi-open item. It's easy to change.