| From: | Joe Conway <mail(at)joeconway(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Chengxi Sun <sunchengxi(at)highgo(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Ian Barwick <barwick(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net> |
| Subject: | Re: "has_column_privilege()" issue with attnums and non-existent columns |
| Date: | 2021-03-30 19:37:28 |
| Message-ID: | ada12d23-954e-9de6-3b22-c712380831c7@joeconway.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/21/21 12:27 PM, Tom Lane wrote:
> I think we may have to adjust the acl.c APIs, or maybe better provide new
> entry points, so that we can have variants of pg_xxx_aclcheck that won't
> throw a hard error upon not finding the row. We cheesily tried to avoid
> adjusting those APIs to support the semantics we need here, and we now see
> that it didn't really work.
Ok, I took a shot at that; see attached.
Questions:
1. I confined the changes to just pg_class_aclcheck/mask
and pg_attribute_aclcheck/mask -- did you intend
that we do this same change across the board? Or
perhaps do the rest of them once we open up pg15
development?
2. This seems more invasive than something we would want
to back patch -- agreed?
Joe
--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development
| Attachment | Content-Type | Size |
|---|---|---|
| has_column_privilege-attnum-fix-jec.01.patch | text/x-patch | 10.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2021-03-30 19:44:05 | Re: pgbench - add pseudo-random permutation function |
| Previous Message | Fujii Masao | 2021-03-30 19:36:07 | Re: Get memory contexts of an arbitrary backend process |