| From: | Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com> |
|---|---|
| To: | Martín Marqués <martin(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: pg_dump with tables created in schemas created by extensions |
| Date: | 2016-08-23 21:48:17 |
| Message-ID: | abb09d01-b836-16d4-0ae0-9ffaca7f3393@BlueTreble.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 8/23/16 3:34 PM, Martín Marqués wrote:
> I found quite some other objects we should be checking as well, but
> this will add some duplication to the tests, as I'd just copy (with
> minor changes) what's in src/bin/pg_dump/t/002_pg_dump.pl
>
> I can't think of a way to avoid this duplication, not that it really
> hurts. We would have to make sure that any new objects added to one
> test, if needed, are added to the other (that's a bit cumbersome).
At one point I had some code that understood what object names (ie:
AGGREGATE, TABLE, etc) went with what catalog tables, what ones lived
inside a schema (as opposed to globally), and which ones were
shared/global (cross-database). I think I needed this for some automatic
handling of comments, but it's been a while. Maybe something like that
would help reduce the duplication...
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
855-TREBLE2 (855-873-2532) mobile: 512-569-9461
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-08-23 22:01:33 | Re: Block level parallel vacuum WIP |
| Previous Message | Andres Freund | 2016-08-23 21:41:43 | Re: dump/restore doesn't preserve row ordering? |