| From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
|---|---|
| To: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, peter(dot)eisentraut(at)2ndquadrant(dot)com |
| Subject: | Re: More issues with expressions always false (no patch) |
| Date: | 2019-12-20 15:35:25 |
| Message-ID: | ab3ba51e-65bc-fdd7-b15c-e0ed6579e893@proxel.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/20/19 1:54 AM, Andreas Karlsson wrote:
> On 12/20/19 1:01 AM, Ranier Vilela wrote:> First case:
>> Third case:
>> \ src \ backend \ utils \ cache \ relcache.c (line 5190)
>> if (relation-> rd_pubactions)
>>
>> It will never be executed, because if relation-> rd_pubactions is
>> true, the function returns on line 5154.
>
> I have not looked into this one in detail, but the free at line 5192
> looks like potentially dead code.
I have looked at it now and it seems like this code has been dead since
the function was originally implemented in 665d1fad99e.
Peter, what do you think?
Andreas
| Attachment | Content-Type | Size |
|---|---|---|
| remove-dead-code.patch | text/x-patch | 581 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2019-12-20 15:43:57 | Re: backup manifests |
| Previous Message | Antonin Houska | 2019-12-20 15:30:38 | Re: MarkBufferDirtyHint() and LSN update |