Re: Perl 5.26 and windows build system

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Victor Wagner <vitus(at)wagner(dot)pp(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Perl 5.26 and windows build system
Date: 2018-10-17 21:22:35
Message-ID: aabe238b-9fd6-f9fc-a98a-c318b7487358@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10/17/2018 05:16 PM, Andrew Dunstan wrote:
>
>
> On 10/17/2018 04:38 AM, Victor Wagner wrote:
>> Colleagues,
>>
>> Since Active State stopped to distribute perl 5.22, we decided to
>> upgrade installer builds to most use recent version available
>> (5.26.1.2601 now).
>>
>> But upstream perl changes policy around this version and no longer
>> adds current directory to the module search path.
>>
>> This doesn't break work of build.pl, which allready handles module
>> search path itself, but breaks install.pl, mkvcbuild.pl and
>> vcregress.pl, which
>> expect to be started from src/tools/msvc.
>>
>> Simple adding
>>
>> use lib ".";
>>
>> to the beginning of these script solves problem.
>
>
> The buildfarm code uses this pattern:
>
>    use File::Spec;
>
>    BEGIN
>    {
>         use lib File::Spec->rel2abs(dirname(__FILE__));
>    }
>
> So that the added path is not the current directory but the one where
> the file lives. I think that's probably a better way to do it.
>
>

This would also need

    use File::Basename;

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2018-10-17 21:27:14 MSVC compilers complain about snprintf
Previous Message Andrew Dunstan 2018-10-17 21:16:15 Re: Perl 5.26 and windows build system