Re: Things I don't like about \du's "Attributes" column

From: Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jim Nasby <jim(dot)nasby(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Things I don't like about \du's "Attributes" column
Date: 2025-04-13 07:43:41
Message-ID: aa9e60b8-60b3-4a0c-8b47-b16a71715061@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11.04.2025 20:09, David G. Johnston wrote:
> However, I do think we are at something committable, though I'd make
> one, maybe two, changes to v8.

Thank you for supporting this patch.

> Valid until -> Password valid until: the timestamp value already
> forces a wide column, adding the word Password to the header to
> clarify what is valid simply provides the same context that the create
> role page provides when it shows the valid until attribute immediately
> below the password attribute. Leaving "valid until" alone retains the
> attribute name tieback.
>
> Connection limit -> Con. limit: maybe this gets rejected on
> translation grounds but the abbreviation here seems obvious and shaves
> 7 characters off the mandatory width for a column that occupies 12
> characters more than the values require.

Yes, it can be done.

<bikeshedding again>
I still have some doubts about these columns. Possibly these columns
changes very rare,
not very often. So, maybe a better solution is to show them only in \du+.
In such case wide of columns is not a problem. But such change requires
changing
"Attributes" column back to one line.
</bikeshedding>

> Even without those changes I as reviewer would concur with the
> proposal and try to move this on from bike-shedding to a go/no-go
> decision (by marking it Ready to Commit) as to whether this is an
> improvement over the status quo.

Sincethe patchrequiresrebaseandimplementationof yoursuggestions,
Idecidedto movethe entrytothenext(July)commitfestandsetthe status to
"Waitingon Author". I hope that I will return to this work in June.
Robert's idea (detailed role permissions report with \du rolename) can
be implemented as a separate work.

--
Pavel Luzanov
Postgres Professional:https://postgrespro.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ryo Kanbayashi 2025-04-13 10:06:06 Re: [PATCH] PGSERVICEFILE as part of a normal connection string
Previous Message Pavel Luzanov 2025-04-13 06:47:34 Re: Adding error messages to a few slash commands