| From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Special-case executor expression steps for common combinations |
| Date: | 2024-07-22 12:33:16 |
| Message-ID: | aa4b1339-b136-4b0c-8ddd-5ebe5ddfd88c@proxel.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 7/4/24 6:26 PM, Daniel Gustafsson wrote:
>> 2) We could generate functions which return void rather than NULL and therefore not have to do a return at all but I am not sure that small optimization and extra clarity would be worth the hassle. The current approach with adding Assert() is ok with me. Daniel, what do you think?
>
> I'm not sure that would move the needle enough to warrant the extra complexity.
> It could be worth pursuing, but it can be done separately from this.
Agreed.
I looked some more at the patch and have a suggestion for code style.
Attaching the diff. Do with them what you wish, for me they make to code
easier to read.
Andreas
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Suggested-style-changes.patch | text/x-patch | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2024-07-22 12:36:40 | Re: Make COPY format extendable: Extract COPY TO format implementations |
| Previous Message | Andrey M. Borodin | 2024-07-22 12:08:55 | Re: WIP: parallel GiST index builds |