| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Table AM Interface Enhancements |
| Date: | 2024-04-02 15:17:10 |
| Message-ID: | aa2448c19205b8f83af88c67a0e5cd5934524455.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 2024-04-02 at 11:49 +0300, Alexander Korotkov wrote:
> I don't like the idea that every custom table AM reltoptions should
> begin with StdRdOptions. I would rather introduce the new data
> structure with table options, which need to be accessed outside of
> table AM. Then reloptions will be a backbox only directly used in
> table AM, while table AM has a freedom on what to store in reloptions
> and how to calculate externally-visible options. What do you think?
Hi Alexander!
I agree with all of that. It will take some refactoring to get there,
though.
One idea is to store StdRdOptions like normal, but if an unrecognized
option is found, ask the table AM if it understands the option. In that
case I think we'd just use a different field in pg_class so that it can
use whatever format it wants to represent its options.
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kartyshov Ivan | 2024-04-02 15:21:34 | Re: [HACKERS] make async slave to wait for lsn to be replayed |
| Previous Message | Jeff Davis | 2024-04-02 15:10:50 | Re: Statistics Import and Export |