Re: pg_dump: Fix dangling pointer in EndCompressorZstd()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, kuznetsovam(at)altlinux(dot)org, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, egori(at)altlinux(dot)org, nickel(at)altlinux(dot)org
Subject: Re: pg_dump: Fix dangling pointer in EndCompressorZstd()
Date: 2025-04-16 22:29:53
Message-ID: aAAvYUxZW7wibC66@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 16, 2025 at 04:19:02PM +0200, Daniel Gustafsson wrote:
> Agreed, while it's perfectly safe today the end method should not make
> assumptions about the use of the private_data pointer upon return and should
> leave it set to NULL.

Indeed. I was just looking at applying what Alexander has sent
because what EndCompressorZstd() not doing what the other methods do
makes no sense. Perhaps you are already on it, Daniel?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2025-04-16 22:31:57 Re: Align memory context level numbering in pg_log_backend_memory_contexts()
Previous Message Michael Paquier 2025-04-16 22:25:19 Re: Rename injection point names in test_aio