From: | Steven Niu <niushiji(at)gmail(dot)com> |
---|---|
To: | Daniil Davydov <3danissimo(at)gmail(dot)com> |
Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Forbid to DROP temp tables of other sessions |
Date: | 2025-03-17 10:32:53 |
Message-ID: | a9f0bf88-a726-4bfd-a602-ee55b2f724e4@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
在 2025/3/17 18:13, Daniil Davydov 写道:
> Hi,
>
> On Mon, Mar 17, 2025 at 4:48 PM Steven Niu <niushiji(at)gmail(dot)com> wrote:
>>
>> 1. namespace.c, if relation->schemaname is pg_temp but myTempNamespace
>> isn't set, the error information might be misleading. Consider checking
>> OidIsValid(myTempNamespace) first.
> Could you please clarify exactly which place in the code we are
> talking about? I think we handle this case in the
> LookupExplicitNamespace call (with all appropriate error information).
>
I mean RangeVarGetRelidExtended(), you deleted the following code:
if (!OidIsValid(myTempNamespace))
relId = InvalidOid; /* this probably can't happen? */
>>
>> 2."you have not any temporary relations" --> "you have no any temporary
>> relations"
> I am not an English speaker, but it seems that "have not" would be
> more correct. Someone has to judge us :)
>
>>
>> 3. Regarding to the code "strncmp(nspname, "pg_temp", 7)", is it ok when
>> the nspname contains something like "pg_temp_1234"? I think we should
>> use strcmp instead of strncmp for exact matching.
> Great catch! I'll fix it. Please, see v3 patch.
>
> --
> Best regards,
> Daniil Davydov
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2025-03-17 10:52:45 | Re: 64 bit numbers vs format strings |
Previous Message | vignesh C | 2025-03-17 10:32:05 | Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided. |