| From: | Radosław Smogura <rsmogura(at)softperience(dot)eu> |
|---|---|
| To: | Josh Berkus <josh(at)agliodbs(dot)com> |
| Cc: | Florian Pflug <fgp(at)phlo(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Subject: | Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected |
| Date: | 2011-07-13 08:35:02 |
| Message-ID: | a872b45c461d2a8817a1e3ffe97a2931@mail.softperience.eu |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 12 Jul 2011 11:11:40 -0700, Josh Berkus wrote:
> Radoslaw,
>
>> For me this discussion is over. I putted my objections and
>> suggestions. Full
>>> review is available in archives, and why to not escape is putted in
>>> review
>>> of your 2nd patch, about scalar values.
>
> Did you install and test the functionality of the patch? I can't
> tell
> from your review whether you got that far.
Yas, patch was tested, and applied. I think in both reviews I marked
that patch does this what Florain said. Examples of double escaping were
taken from one of patch (I think from this about scalar values).
If I should I will bump this patches up.
Regards,
Radosław Smogura
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2011-07-13 08:40:20 | Re: WIP: Fast GiST index build |
| Previous Message | Heikki Linnakangas | 2011-07-13 08:33:17 | Re: WIP: Fast GiST index build |