Re: pg_basebackup check vs Windows file path limits

On 2023-07-06 Th 09:50, Daniel Gustafsson wrote:
>> On 5 Jul 2023, at 14:49, Andrew Dunstan<andrew(at)dunslane(dot)net> wrote:
>> On 2023-07-04 Tu 16:54, Daniel Gustafsson wrote:
>>>> On 4 Jul 2023, at 20:19, Andrew Dunstan<andrew(at)dunslane(dot)net>
>>>> wrote:
>>>>
>>>> But sadly we're kinda back where we started. fairywren is failing on REL_16_STABLE. Before the changes the failure occurred because the test script was unable to create the file with a path > 255. Now that we have a way to create the file the test for pg_basebackup to reject files with names > 100 fails, I presume because the server can't actually see the file. At this stage I'm thinking the best thing would be to skip the test altogether on windows if the path is longer than 255.
>>>>
>>> That does sound like a fairly large hammer for a nail small enough that we
>>> should be able to fix it, but I don't have any other good ideas off the cuff.
>> Not sure it's such a big hammer. Here's a patch.
> No objections to the patch, LGTM.

Thanks. pushed with a couple of tweaks.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com