Re: Mingw task for Cirrus CI

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: Mingw task for Cirrus CI
Date: 2022-10-18 12:37:32
Message-ID: a70d07c8-1f77-c1d4-48ed-73fcc799df07@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Thanks for the patch!

On 10/18/22 12:49, Melih Mutlu wrote:
>
>
> You can find the updated patch attached.
>

Does it makes sense to set these at 'Windows - Server 2019, MinGW64 -
Meson' task:

env:
    ...
    CHERE_INVOKING: 1
    BASH_EXE: C:\msys64\usr\bin\bash.exe

'CHERE_INVOKING: 1' will cause bash.exe to start from current working
directory(%CIRRUS_WORKING_DIR%).

In this way, there is no need for
'cd %CIRRUS_WORKING_DIR%' when using bash.exe,
also no need for 'BUILD_DIR' environment variable.

i.e:

configure_script: |
    %BASH_EXE% -lc "meson setup --buildtype debug -Dcassert=true
-Db_pch=true -DTAR=%TAR% build"

will work.

Regards,
Nazir Bilal Yavuz

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2022-10-18 12:53:32 Re: TRAP: FailedAssertion("prev_first_lsn < cur_txn->first_lsn", File: "reorderbuffer.c", Line: 927, PID: 568639)
Previous Message Tomas Vondra 2022-10-18 12:03:14 Re: PATCH: Using BRIN indexes for sorted output