| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | remove some STATUS_* symbols |
| Date: | 2019-12-29 10:33:34 |
| Message-ID: | a6f91ead-0ce4-2a34-062b-7ab9813ea308@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I have found the collection of STATUS_* defines in c.h a bit curious.
There used to be a lot more even that have been removed over time.
Currently, STATUS_FOUND and STATUS_WAITING are only used in one group of
functions each, so perhaps it would make more sense to remove these from
the global namespace and make them a local concern.
Attached are two patches to remove these two symbols. STATUS_FOUND can
be replaced by a simple bool. STATUS_WAITING is replaced by a separate
enum.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Remove-STATUS_FOUND.patch | text/plain | 5.7 KB |
| 0002-Remove-STATUS_WAITING.patch | text/plain | 12.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-12-29 11:11:03 | Re: pgbench - use pg logging capabilities |
| Previous Message | Andrey Borodin | 2019-12-29 09:13:27 | Re: Disallow cancellation of waiting for synchronous replication |