| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
| Cc: | Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: WIN32 pg_import_system_collations |
| Date: | 2022-12-01 07:46:41 |
| Message-ID: | a6c3880a-e887-5ac5-c0bd-f72604ceb53d@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10.11.22 11:08, Juan José Santamaría Flecha wrote:
> This looks pretty good to me. The refactoring of the
> non-Windows parts
> makes sense. The Windows parts look reasonable on manual
> inspection,
> but again, I don't have access to Windows here, so someone else
> should
> also look it over.
>
> I was going to say that at least it is getting tested on the CI, but
> I have found out that meson changes version(). That is fixed in this
> version.
>
>
> Now is currently failing due to [1], so maybe we can leave this patch on
> hold until that's addressed.
>
> [1]
> https://www.postgresql.org/message-id/CAC%2BAXB1wJEqfKCuVcNpoH%3Dgxd61N%3D7c2fR3Ew6YRPpSfEUA%3DyQ%40mail.gmail.com <https://www.postgresql.org/message-id/CAC%2BAXB1wJEqfKCuVcNpoH%3Dgxd61N%3D7c2fR3Ew6YRPpSfEUA%3DyQ%40mail.gmail.com>
What is the status of this now? I think the other issue has been addressed?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yugo NAGATA | 2022-12-01 07:53:11 | Re: SI-read predicate locks on materialized views |
| Previous Message | Peter Eisentraut | 2022-12-01 07:43:19 | Re: meson PGXS compatibility |